🚚 🙈 🐳 Reorganized Repository; Updated docker… #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o; Updated app Dockerfile Moved laravel app to www folder; Updated docker-compose version to 3.7; Add vscode and phpstorm+all from gitignore.io to .gitignore; Separated app's Dockerfile into 2 different stages to allow future use of a single Dockerfile in both development and production; In app's Dockerfile dev stage added the entrypont script and the .env file to be used as a template with dockerize;
Member
|
Thanks @yurikoster1 . Excellent job! Your pull request was moved to new branch, because the course used the old structure, but I will recommend it to our students. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…-compose; use gitignore.io; Updated app Dockerfile
Moved laravel app to www folder;
Updated docker-compose version to 3.7;
Add vscode and phpstorm+all from gitignore.io to .gitignore;
Separated app's Dockerfile into 2 different stages to allow future use of a single Dockerfile in both development and production;
In app's Dockerfile dev stage added the entrypont script and the .env file to be used as a template with dockerize;