Skip to content

Sync README.en.md with last two commits to README.md#58

Merged
argentinaluiz merged 3 commits intomainfrom
copilot/update-readme-with-last-commit
Mar 28, 2026
Merged

Sync README.en.md with last two commits to README.md#58
argentinaluiz merged 3 commits intomainfrom
copilot/update-readme-with-last-commit

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 28, 2026

README.en.md was out of sync with two recent commits that updated the Docker Engine installation section of README.md.

Changes

From de385d4 (missed entirely):

  • Moved "For other Linux distributions" note to appear before the install commands block
  • Updated install commands: apt-getapt
  • Replaced old echo | sudo tee docker.list repository setup with the current DEB822 format:
    sudo tee /etc/apt/sources.list.d/docker.sources <<EOF
    Types: deb
    URIs: https://download.docker.com/linux/ubuntu
    Suites: $(. /etc/os-release && echo "${UBUNTU_CODENAME:-$VERSION_CODENAME}")
    Components: stable
    Signed-By: /etc/apt/keyrings/docker.asc
    EOF
  • Removed the obsolete "Add Docker's repository to Ubuntu's sources list" block (old curl | gpg --dearmor method)

From 3aa8640 (partially applied):

  • > **For other Linux distributions** heading format (was > **NOTE:**)
  • Replaced "Re-access Ubuntu and start Docker" with auto-start note + service docker status check + service docker start for manual fallback
  • Added missing hello-world post-install verification step with expected output in a code block

📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.

Copilot AI changed the title [WIP] Update README with latest changes from last commit Sync README.en.md with latest README.md Docker installation changes Mar 28, 2026
Copilot AI requested a review from argentinaluiz March 28, 2026 22:25
Copilot AI changed the title Sync README.en.md with latest README.md Docker installation changes Sync README.en.md with last two commits to README.md Mar 28, 2026
@argentinaluiz argentinaluiz marked this pull request as ready for review March 28, 2026 22:36
Copilot AI review requested due to automatic review settings March 28, 2026 22:36
@argentinaluiz argentinaluiz merged commit 7a98eb8 into main Mar 28, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Synchronizes README.en.md with recent updates to the Docker Engine installation instructions so the English README matches the current Ubuntu/WSL2 Docker setup flow.

Changes:

  • Moves the “For other Linux distributions” note above the Ubuntu-specific install commands.
  • Updates Ubuntu install steps to use apt and Docker’s current DEB822 (docker.sources) repository configuration.
  • Improves post-install guidance: service status/start instructions and a hello-world verification step.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +548 to +550
```bash
sudo service docker status
```
Copy link

Copilot AI Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command in this code block has an extra leading space before sudo, which makes copy/paste inconsistent with the other command blocks in this section. Remove the leading whitespace so the command is flush-left inside the fenced block.

Copilot uses AI. Check for mistakes.
Comment on lines 554 to 556
```bash
sudo service docker start
sudo service docker start
```
Copy link

Copilot AI Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code block also has an extra leading space before sudo. Please remove it to keep command examples consistent and avoid copying a leading space into shells/tools that treat it specially.

Copilot uses AI. Check for mistakes.
Comment on lines +573 to +574
"Hello from Docker!
This message shows that your installation appears to be working correctly..."
Copy link

Copilot AI Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The expected hello-world output snippet is inaccurate/ill-formed: it starts with a double quote but never closes it, and the real Docker output does not include surrounding quotes. Update the snippet to match the actual docker run hello-world output format (no quotes) and ensure it’s syntactically consistent.

Suggested change
"Hello from Docker!
This message shows that your installation appears to be working correctly..."
Hello from Docker!
This message shows that your installation appears to be working correctly.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants