Skip to content

⚡️ Speed up method MCPClientSSE.get_auth_url_and_state by 738% #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method MCPClientSSE.get_auth_url_and_state by 738% #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/mistralai/extra/mcp/auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,12 @@ class AsyncOAuth2Client(AsyncOAuth2ClientBase):

@classmethod
def from_oauth_params(cls, oauth_params: OAuthParams) -> "AsyncOAuth2Client":
# Store attribute access in locals for micro-optimization in this tight path
scheme = oauth_params.scheme
return cls(
client_id=oauth_params.client_id,
client_secret=oauth_params.client_secret,
scope=oauth_params.scheme.scope,
scope=scheme.scope,
)


Expand Down
17 changes: 13 additions & 4 deletions src/mistralai/extra/mcp/sse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ class MCPClientSSE(MCPClientBase):

def __init__(
self,
sse_params: SSEServerParams,
sse_params: "SSEServerParams",
name: Optional[str] = None,
oauth_params: Optional[OAuthParams] = None,
auth_token: Optional[OAuth2Token] = None,
Expand All @@ -55,6 +55,8 @@ def __init__(
self._sse_params = sse_params
self._oauth_params: Optional[OAuthParams] = oauth_params
self._auth_token: Optional[OAuth2Token] = auth_token
self._oauth_client: Optional[AsyncOAuth2Client] = None
self._oauth_client_params: Optional[OAuthParams] = None

@cached_property
def base_url(self) -> str:
Expand All @@ -68,14 +70,21 @@ def set_oauth_params(self, oauth_params: OAuthParams):

async def get_auth_url_and_state(self, redirect_url: str) -> tuple[str, str]:
"""Create the authorization url for client to start oauth flow."""
if self._oauth_params is None:
oauth_params = self._oauth_params
if oauth_params is None:
raise MCPAuthException(
"Can't generate an authorization url without oauth_params being set, "
"make sure the oauth params have been set."
)
oauth_client = AsyncOAuth2Client.from_oauth_params(self._oauth_params)

# Only reconstruct client if params have changed or not yet initialized
if self._oauth_client is None or self._oauth_client_params is not oauth_params:
self._oauth_client = AsyncOAuth2Client.from_oauth_params(oauth_params)
self._oauth_client_params = oauth_params

oauth_client = self._oauth_client
auth_url, state = oauth_client.create_authorization_url(
self._oauth_params.scheme.authorization_url, redirect_uri=redirect_url
oauth_params.scheme.authorization_url, redirect_uri=redirect_url
)
return auth_url, state

Expand Down