Skip to content

⚡️ Speed up method MCPClientBase._convert_content by 6% #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method MCPClientBase._convert_content by 6% #117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 10 additions & 14 deletions src/mistralai/extra/mcp/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,27 +29,21 @@ class MCPClientProtocol(Protocol):

_name: str

async def initialize(self, exit_stack: Optional[AsyncExitStack]) -> None:
...
async def initialize(self, exit_stack: Optional[AsyncExitStack]) -> None: ...

async def aclose(self) -> None:
...
async def aclose(self) -> None: ...

async def get_tools(self) -> list[FunctionTool]:
...
async def get_tools(self) -> list[FunctionTool]: ...

async def execute_tool(
self, name: str, arguments: dict
) -> list[TextChunkTypedDict]:
...
) -> list[TextChunkTypedDict]: ...

async def get_system_prompt(
self, name: str, arguments: dict[str, Any]
) -> MCPSystemPrompt:
...
) -> MCPSystemPrompt: ...

async def list_system_prompts(self) -> ListPromptsResult:
...
async def list_system_prompts(self) -> ListPromptsResult: ...


class MCPClientBase(MCPClientProtocol):
Expand All @@ -58,15 +52,17 @@ class MCPClientBase(MCPClientProtocol):
_session: ClientSession

def __init__(self, name: Optional[str] = None):
self._name = name or self.__class__.__name__
self._name = name if name is not None else self.__class__.__name__
self._exit_stack: Optional[AsyncExitStack] = None
self._is_initialized = False

def _convert_content(
self, mcp_content: Union[TextContent, ImageContent, EmbeddedResource]
) -> TextChunkTypedDict:
if not mcp_content.type == "text":
# Slightly faster comparison
if mcp_content.type != "text":
raise MCPException("Only supporting text tool responses for now.")
# Use direct dict literal construction, as before
return {"type": "text", "text": mcp_content.text}

def _convert_content_list(
Expand Down