Skip to content

⚡️ Speed up method CompletionTrainingParametersIn.serialize_model by 17% #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method CompletionTrainingParametersIn.serialize_model by 17% #120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 17 additions & 13 deletions src/mistralai/models/completiontrainingparametersin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,44 +46,48 @@ class CompletionTrainingParametersIn(BaseModel):

@model_serializer(mode="wrap")
def serialize_model(self, handler):
optional_fields = [
# Use tuple/lists for fastest membership test, all fields are a small, fixed set
optional_fields = {
"training_steps",
"learning_rate",
"weight_decay",
"warmup_fraction",
"epochs",
"seq_len",
"fim_ratio",
]
nullable_fields = [
}
nullable_fields = {
"training_steps",
"weight_decay",
"warmup_fraction",
"epochs",
"seq_len",
"fim_ratio",
]
null_default_fields = []
}
null_default_fields = set()

serialized = handler(self)

# Precompute fields set and other invariants local to the method for perf
pydantic_fields_set = self.__pydantic_fields_set__

# Micro-optimize reference lookups & minimize attribute access in loop
model_fields = type(self).model_fields
m = {}

for n, f in type(self).model_fields.items():
# Avoid repeatedly calling .get/.pop when iterating: iterate directly on model_fields
for n, f in model_fields.items():
k = f.alias or n
val = serialized.get(k)
serialized.pop(k, None)
# Use pop once, default None if not present
val = serialized.pop(k, None)

optional_nullable = k in optional_fields and k in nullable_fields
is_set = (
self.__pydantic_fields_set__.intersection({n})
or k in null_default_fields
) # pylint: disable=no-member
is_set = n in pydantic_fields_set or k in null_default_fields # pylint: disable=no-member

if val is not None and val != UNSET_SENTINEL:
m[k] = val
elif val != UNSET_SENTINEL and (
not k in optional_fields or (optional_nullable and is_set)
k not in optional_fields or (optional_nullable and is_set)
):
m[k] = val

Expand Down