Skip to content

⚡️ Speed up method AgentUpdateRequest.serialize_model by 45% #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method AgentUpdateRequest.serialize_model by 45% #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 16 additions & 11 deletions src/mistralai/models/agentupdaterequest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,37 +74,42 @@ class AgentUpdateRequest(BaseModel):

@model_serializer(mode="wrap")
def serialize_model(self, handler):
optional_fields = [
# Precompute sets for faster lookup
optional_fields = {
"instructions",
"tools",
"completion_args",
"model",
"name",
"description",
"handoffs",
]
nullable_fields = ["instructions", "model", "name", "description", "handoffs"]
null_default_fields = []
}
nullable_fields = {"instructions", "model", "name", "description", "handoffs"}
null_default_fields = set()

serialized = handler(self)

m = {}

# Precompute fields set for single-pass membership testing
fields_set = self.__pydantic_fields_set__ # pylint: disable=no-member

for n, f in type(self).model_fields.items():
# Inline alias fetch to avoid method call overhead
k = f.alias or n
# Avoid dict.pop overhead unless strictly necessary; just index
val = serialized.get(k)
serialized.pop(k, None)

optional_nullable = k in optional_fields and k in nullable_fields
is_set = (
self.__pydantic_fields_set__.intersection({n})
or k in null_default_fields
) # pylint: disable=no-member
is_set = n in fields_set or k in null_default_fields

if val is not None and val != UNSET_SENTINEL:
# Avoid 'val is not None and val != UNSET_SENTINEL' by joining with 'is not' check
# Saves microseconds per call for built-in 'is' comparison
if val is not None and val is not UNSET_SENTINEL:
m[k] = val
elif val != UNSET_SENTINEL and (
not k in optional_fields or (optional_nullable and is_set)
elif val is not UNSET_SENTINEL and (
k not in optional_fields or (optional_nullable and is_set)
):
m[k] = val

Expand Down