Skip to content

Ran ruff on main branch #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Ran ruff on main branch #102

wants to merge 3 commits into from

Conversation

@aseembits93
Copy link
Contributor

@aseembits93 aseembits93 commented Apr 1, 2025 •
edited by github-actions bot
Loading

User description

ran ruff check --fix . ; ruff format .

PR Type

  • Enhancement

Description

  • Replace type cast to use string literal annotations.

  • Reformat inline comments and docstrings.

  • Simplify condition check for list content.

  • Tidy exception handling in configuration parser.

Changes walkthrough 📝

Relevant files
Enhancement
cli_common.py
Update cast usage with string literal                                       

codeflash/cli_cmds/cli_common.py

  • Updated cast call to use string literal type.
  • Minor formatting adjustments.
    		• +1/-1     
    cmd_init.py
    Refactor CLI init functions and cast usage                             

    codeflash/cli_cmds/cmd_init.py

  • Updated exception handling in pyproject_toml function.
  • Replaced cast calls using string literal types.
  • Reformatted Confirm.ask arguments.
  • Improved code formatting in CLI initialization.
    		• +11/-10 
    functions_to_optimize.py
    Simplify function existence check                                               

    codeflash/discovery/functions_to_optimize.py

  • Simplified check from len(filtered_list) to condition.
  • Improves code clarity.
    		• +1/-1     
    models.py
    Update cast in model equality check                                           

    codeflash/models/models.py

  • Changed cast call in __eq__ to use string literal.
  • Enhances type checking clarity.
    		• +1/-1     
    Formatting
    config_parser.py
    Fix comment formatting in config parser                                   

    codeflash/code_utils/config_parser.py

  • Adjusted in-line comment formatting.
  • Minor style update in config parsing.
    		• +1/-1     
    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
    •

    @github-actions
    Copy link

    github-actions bot commented Apr 1, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Type Casting

    Ensure that the use of string literal annotations in the cast (e.g., casting to "dict[str, str]") is consistent with the expected type usage in downstream code.

     
    return cast("dict[str, str]", inquirer.prompt([inquirer.Path(*new_args, **new_kwargs)]))
    Exception Handling

    Verify that the switched exception handling (using a bare "except Exception:" without logging or accessing the exception) still provides enough context in case of failures during configuration parsing.

     
    except Exception:
    return True

    @github-actions
    Copy link

    github-actions bot commented Apr 1, 2025

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @KRRT7 KRRT7 mentioned this pull request Apr 1, 2025
    Closed
    codeflash-ai bot added a commit that referenced this pull request Apr 4, 2025
    @codeflash-ai
    ⚡️ Speed up function should_modify_pyproject_toml by 48% in PR #102 …
    ff0fc80 
    …(`ruff-format`)

To optimize the provided Python script, I have made some improvements to the performance and memory efficiency. made.

1. Moved imports inside functions when they are not needed globally to reduce initial load time and potentially minimize memory footprint.
2. Changed `tomlkit.exceptions.NonExistentKey` to `KeyError` as `tomlkit` does not have `NonExistentKey` and works with standard `KeyError`.
3. Replaced multiple dictionary lookup operations with dict's `get` method where appropriate.
4. Used list and dictionary comprehensions where possible for better performance.




Explanation.
- Imports: Restricted global imports and moved the `import` statements within the functions where they are needed.
- Dictionary lookups: Improved dictionary lookups by making use of `.get()` method which is slightly faster when checking for variable existence and using comprehensions.
- Combined certain for loops and conditionals reducing code redundancy and enhancing readability.
- Replaced the custom `tomlkit.exceptions.NonExistentKey` by `KeyError`.

The code will function in the same way as before but now should be slightly more efficient.
    @codeflash-ai codeflash-ai bot mentioned this pull request Apr 4, 2025
    Closed
    @codeflash-ai
    Copy link
    Contributor

    codeflash-ai bot commented Apr 4, 2025

    ⚡️ Codeflash found optimizations for this PR

    📄 48% (0.48x) speedup for should_modify_pyproject_toml in codeflash/cli_cmds/cmd_init.py

    ⏱️ Runtime : 40.6 milliseconds → 27.4 milliseconds (best of 105 runs)

    I created a new dependent PR with the suggested changes. Please review:

    If you approve, it will be merged into this PR (branch ruff-format).

    @aseembits93 aseembits93 deleted the ruff-format branch May 28, 2025 02:27
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    No reviews

    Assignees

    No one assigned

    Labels

    Review effort 2/5

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    3 participants

    @aseembits93 @KRRT7