feat: clarify improvement type in async optimization display #1149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Show whether improvement is from runtime, throughput, or concurrency in the display output (e.g., "45% runtime improvement" instead of just "45% improvement").
Add expected_acceptance_reason field to TestConfig and update the improvement regex to capture and validate the improvement type.
Ensure the async E2E test verifies that optimizations are accepted for the correct reason (concurrency improvement).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Messages now show "📈 3037% concurrency improvement" instead of just "📈 3037% improvement", making it clear when an optimization was accepted based on concurrency rather than runtime.
Test plan