[FIX] correctly detect codeflash import#1201
Merged
mohammedahmed18 merged 1 commit intomainfrom Jan 30, 2026
Merged
Conversation
Saga4
approved these changes
Jan 30, 2026
Saga4
reviewed
Jan 30, 2026
| has_trailing_semicolon: bool | ||
|
|
||
|
|
||
| codeflash_import_pattern = re.compile( |
Contributor
There was a problem hiding this comment.
There could be nested import in cjs files too like conditional imports etc.
Contributor
Author
There was a problem hiding this comment.
this regex for capturing our own instrumentation which is a basic import
so we are good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this fixes the issue where codeflash import is not added because the generated test has the word codeflash
ReferenceError: codeflash is not defined 302 | } 303 | > 304 | const result = await codeflash.capture('PlainTextStagingStrategy.save', '8', PlainTextStagingStrategy.save.bind(PlainTextStagingStrategy), context) | ^ 305 | 306 | expect(result).toEqual({ success: true, storageType: 'plain_text' }) 307 | expect(mockedFindFirst).toHaveBeenCalledTimes(1)