fix: validate JS/TS functions are exported before optimization#1214
Merged
misrasaurabh1 merged 2 commits intomainfrom Jan 31, 2026
Merged
fix: validate JS/TS functions are exported before optimization#1214misrasaurabh1 merged 2 commits intomainfrom
misrasaurabh1 merged 2 commits intomainfrom
Conversation
For JavaScript and TypeScript, non-exported functions cannot be imported by tests, making optimization impossible. Previously, codeflash would generate tests that try to import non-exported functions, leading to confusing runtime errors like "Expected function 'foo' but got undefined". This change adds early validation when the user specifies a function to optimize via --function flag. If the function is not exported, codeflash now shows a clear error message explaining the issue and how to fix it. Example error message: > Function 'getEnvLogLevel' is not exported from src/utils/AppUtils.ts. > In JavaScript/TypeScript, only exported functions can be optimized > because tests need to import them. > To fix: Add 'export' keyword to the function declaration, e.g.: > export const getEnvLogLevel = ... Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
a5ddcd2 to
f4482d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Previously, codeflash would generate tests that try to import non-exported functions, leading to confusing runtime errors like:
Solution
Now codeflash validates export status early and shows a helpful error message:
Test plan
pytest tests/test_languages/test_import_resolver.py -v)🤖 Generated with Claude Code