Conversation
…s/ folders When a project is located inside a directory named "tests" (e.g., /home/user/tests/myproject), source files were incorrectly filtered as test files because the full path contained "/tests/". The fix ensures directory pattern matching (/test/, /tests/, /__tests__/) only applies to the relative path from project root, not parent directories. If the relative path cannot be computed, we now skip directory pattern matching entirely instead of checking the full path. Example: - Before: /home/user/tests/myproject/src/utils.ts was filtered as test file - After: Only checks if /src/utils.ts contains /tests/ (correctly returns false) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes incorrect test file filtering when a project is located inside a directory named "tests" (e.g.,
/home/user/tests/myproject).Problem
When running codeflash on a project stored in a path containing
/tests/, source files were incorrectly filtered as test files:The issue was in
is_test_file()which checked for/tests/pattern in the full path instead of the relative path from project root.Root Cause
If the condition failed for any reason,
relative_pathremained the full path, which could contain/tests/from parent directories.Solution
Test Results
Before fix:
After fix:
Test plan
/Users/saga4/orgs/tests/n8ncompareValuesis now discovered (was filtered before)Generated with Claude Code