Skip to content

fix: update license format to use license-files#1503

Merged
KRRT7 merged 1 commit intomainfrom
fix-codeflash-benchmark-build
Feb 17, 2026
Merged

fix: update license format to use license-files#1503
KRRT7 merged 1 commit intomainfrom
fix-codeflash-benchmark-build

Conversation

@KRRT7
Copy link
Collaborator

@KRRT7 KRRT7 commented Feb 17, 2026

Summary

Replace deprecated license table format with modern license-files array in both main package and codeflash-benchmark subpackage.

Changes

  • Use license-files = ["LICENSE"] instead of license = {text = "BSL-1.1"}
  • Add LICENSE file to root directory
  • Add LICENSE and README.md to codeflash-benchmark/

Resolves

Fixes the setuptools deprecation warning about TOML table license format that will become unsupported by 2027-Feb-18.

Replace deprecated license table format with modern license-files array
in both main package and codeflash-benchmark subpackage. This resolves
the setuptools deprecation warning about TOML table license format.

Changes:
- Use license-files = ["LICENSE"] instead of license = {text = "BSL-1.1"}
- Add LICENSE file to root directory
- Add LICENSE and README.md to codeflash-benchmark/
@KRRT7 KRRT7 merged commit fc9cdf8 into main Feb 17, 2026
29 checks passed
@KRRT7 KRRT7 deleted the fix-codeflash-benchmark-build branch February 17, 2026 06:01
authors = [{ name = "CodeFlash Inc.", email = "contact@codeflash.ai" }]
requires-python = ">=3.9"
readme = "README.md"
license-files = ["LICENSE"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue: CRLF line endings introduced

All files in this PR have been converted from LF to CRLF line endings. The pyproject.toml on main uses LF (Unix) line endings, but this PR changes it to CRLF (Windows). This causes the entire file to show as changed in the diff rather than just the licenselicense-files line.

Please re-save these files with LF line endings to keep the diff minimal and consistent with the rest of the repo. In most editors you can change this in the status bar (e.g., VS Code: click "CRLF" → "LF").


3. To specify a Change Date.

4. Not to modify this License in any other way. No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: Missing trailing newline

This file is missing a trailing newline at the end. POSIX convention expects text files to end with a newline character. Consider adding one.

@claude
Copy link
Contributor

claude bot commented Feb 17, 2026

PR Review Summary

Prek Checks

Passed — No Python files changed in this PR, so ruff check/format were skipped (no files to check).

Code Review

Changes reviewed: pyproject.toml, codeflash-benchmark/pyproject.toml, LICENSE (x2), codeflash-benchmark/README.md

The only functional change is replacing the deprecated license = {text = "BSL-1.1"} with license-files = ["LICENSE"] in both pyproject.toml files, along with adding the required LICENSE and README.md files to codeflash-benchmark/.

Issues found:

# Severity Issue Location
1 Medium CRLF line endings introduced — All files changed from LF → CRLF, causing full-file diffs instead of single-line changes. The rest of the repo uses LF. pyproject.toml, codeflash-benchmark/pyproject.toml
2 Low Missing trailing newline — Both LICENSE files are missing a trailing newline (POSIX convention). LICENSE, codeflash-benchmark/LICENSE

No critical bugs, security vulnerabilities, or breaking API changes found. The license format update is correct and addresses the setuptools deprecation warning.

Test Coverage

No Python source files were changed in this PR — only pyproject.toml, LICENSE, and README.md files. Test coverage analysis is not applicable.

Optimization PRs

Checked 4 open codeflash-ai[bot] PRs targeting main:

None are safe to merge — all have failing CI checks.


Last updated: 2026-02-17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments