fix: use correct subagent flag in checkpoint guard#1665
Merged
Conversation
The checkpoint guard referenced `args.agent` which is never set — the actual CLI flag is `--subagent`. The old check always evaluated to False, making the condition equivalent to just `self.args.all`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
PR Review SummaryPrek Checks✅ All checks pass — ruff check and ruff format both passed with no issues. Mypy
Code Review✅ No issues found. This is a clean, correct 1-line fix:
Test Coverage
Overall Assessment✅ LGTM — Straightforward bug fix. The old code silently failed (always returned Last updated: 2026-02-25 |
KRRT7
requested changes
Feb 25, 2026
Collaborator
KRRT7
left a comment
There was a problem hiding this comment.
@aseembits93 you're bumping the benchmark package, not codeflash here
Contributor
Author
|
@KRRT7 fixed |
Collaborator
|
@aseembits93 big jump? |
Contributor
Author
i only see a single line of change, i think it was out of sync with main before? |
Collaborator
|
oops, I misread the update |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
optimizer.pyreferencedargs.agent, which is never defined on the CLI args namespace — the actual flag is--subagent(args.subagent).getattr(self.args, "agent", False)always returnedFalse, the condition was effectively justself.args.all, meaning checkpointing was never skipped in subagent mode as intended.Test plan
--all --subagentskips checkpoint creation--allwithout--subagentstill creates checkpoint🤖 Generated with Claude Code