Skip to content

fix/trigger_cc_on_multiple_commits#1869

Open
Saga4 wants to merge 2 commits intomainfrom
fix/trigger_cc_on_multiple_commits
Open

fix/trigger_cc_on_multiple_commits#1869
Saga4 wants to merge 2 commits intomainfrom
fix/trigger_cc_on_multiple_commits

Conversation

@Saga4
Copy link
Contributor

@Saga4 Saga4 commented Mar 18, 2026

No description provided.

@claude
Copy link
Contributor

claude bot commented Mar 18, 2026

Claude finished @Saga4's task in 2m 22s —— View job


PR Review Summary

PR size: SMALL (37 lines changed across 4 production files)

Prek Checks

ruff check — passed
ruff format — passed
⚠️ mypy — 27 pre-existing errors in 3 files; none introduced by this PR.

Code Review

The PR adds a --since-commit flag that diffs from a given commit hash to HEAD, enabling optimization of all functions changed across multiple commits in a session. The change is propagated cleanly through the call chain: CLI → Optimizerget_functions_to_optimizeget_functions_within_git_diffget_git_diff.

One minor note:

optimizer.py:161 uses getattr(self.args, "since_commit", None) instead of self.args.since_commit. Since the argument is always registered in _build_parser(), this is safe but inconsistent with how other args are accessed in optimizer.py. It suggests defensive coding for a case that won't happen (arg not being present). Not a bug, just a minor style note. Fix this →

No bugs, security issues, or breaking API changes found.

Duplicate Detection

No duplicates detected. The since_commit parameter follows the same pattern as only_this_commit already present in get_git_diff.

Optimization PRs

PR #1877 (codeflash/optimize-pr1874-2026-03-19T09.01.32) targeting the java-tracer branch has merge conflicts and CI failures, but was created today (< 3 days old) — leaving open to allow the base branch to stabilize.


Last updated: 2026-03-19

@codeflash-ai
Copy link
Contributor

codeflash-ai bot commented Mar 18, 2026

⚡️ Codeflash found optimizations for this PR

📄 14% (0.14x) speedup for Optimizer.get_optimizable_functions in codeflash/optimization/optimizer.py

⏱️ Runtime : 491 microseconds 431 microseconds (best of 250 runs)

A dependent PR with the suggested changes has been created. Please review:

If you approve, it will be merged into this PR (branch fix/trigger_cc_on_multiple_commits).

Static Badge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant