perf: cache site.getsitepackages() result#2128
Merged
KRRT7 merged 2 commits intocf-perf-improvementsfrom May 7, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cache
site.getsitepackages()with@lru_cache(maxsize=1)to avoid repeated path resolution on every call topath_belongs_to_site_packages().Part of #2132 — targeted E2E pipeline performance improvements.
Problem
site.getsitepackages()callsos.path.join+ path resolution for every site-packages directory on every invocation.path_belongs_to_site_packages()is called hundreds of times per optimization run. Site-packages paths never change during a process lifetime — resolving them repeatedly is pure waste.Solution
Extract
_get_site_packages_paths()cached helper with@lru_cache(maxsize=1). First call resolves paths, all subsequent calls return the cached tuple.Changes
codeflash/code_utils/code_utils.py: Extract cached helpertests/test_code_utils.py: 4 new tests covering caching behavior, true/false paths, and symlinksTest plan
uv run pytest tests/test_code_utils.py -k site_packages -vcache_clear()to avoid cross-test contamination