perf: avoid double dict lookup for line profiler results#2131
Merged
KRRT7 merged 2 commits intocf-perf-improvementsfrom May 7, 2026
Merged
perf: avoid double dict lookup for line profiler results#2131KRRT7 merged 2 commits intocf-perf-improvementsfrom
KRRT7 merged 2 commits intocf-perf-improvementsfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
if key in dict: dict[key]with single.get()call inhandle_duplicate_candidate().Part of #2132 — targeted E2E pipeline performance improvements.
Problem
handle_duplicate_candidate()used the pattern:This computes the hash twice and performs two dict lookups. The dict is
dict[str, str]soNoneis never a valid value.Solution
Single
.get()with a guard:One hash, one lookup, same semantics.
Changes
codeflash/models/models.py: Single.get()+ guard instead ofin+ subscripttests/test_candidate_evaluation_context.py: 3 tests covering existing key, missing key, and no corruptionTest plan
uv run pytest tests/test_candidate_evaluation_context.py -v