fix: use native path format for pytest subprocess args on Windows#2138
Merged
KRRT7 merged 1 commit intofix/test-files-silent-dedupfrom May 8, 2026
Merged
fix: use native path format for pytest subprocess args on Windows#2138KRRT7 merged 1 commit intofix/test-files-silent-dedupfrom
KRRT7 merged 1 commit intofix/test-files-silent-dedupfrom
Conversation
KRRT7
force-pushed
the
fix/windows-junitxml-path
branch
2 times, most recently
from
9babf0a to
7f5f229
Compare
KRRT7
force-pushed
the
fix/test-files-silent-dedup
branch
from
9459c5a to
46f63d2
Compare
KRRT7
force-pushed
the
fix/windows-junitxml-path
branch
from
7f5f229 to
38c2445
Compare
5 tasks
KRRT7
force-pushed
the
fix/test-files-silent-dedup
branch
from
46f63d2 to
72b75d6
Compare
KRRT7
force-pushed
the
fix/windows-junitxml-path
branch
from
38c2445 to
3e83a5c
Compare
KRRT7
force-pushed
the
fix/test-files-silent-dedup
branch
from
72b75d6 to
5208de8
Compare
KRRT7
force-pushed
the
fix/windows-junitxml-path
branch
from
3e83a5c to
1728cd4
Compare
- Remove .as_posix() from --junitxml and --rcfile subprocess arguments; use native path format (str(path)) which works on all platforms. - Replace get_cross_platform_subprocess_run_args() in execute_test_subprocess with plain subprocess.run(capture_output=True, close_fds=False). The Windows-specific CREATE_NEW_PROCESS_GROUP and stdin=DEVNULL flags caused pytest to sporadically fail to write its junitxml output file, resulting in flaky test_pickle_patcher failures. Matches the working implementation in codeflash-python. - Fix 10 pre-existing mypy errors in support.py (bare generics, re-export issues, missing attribute guards).
KRRT7
force-pushed
the
fix/test-files-silent-dedup
branch
from
c58d349 to
50f5070
Compare
KRRT7
force-pushed
the
fix/windows-junitxml-path
branch
from
1728cd4 to
aa98bc1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.as_posix()from--junitxmland--rcfilesubprocess arguments inPythonSupporttest runners.as_posix()produces mixed-format paths (C:/Users/...) that pytest's XML writer can't handletest_run_and_parse_picklepatchfailure on Windows CIsupport.py(bare generics, re-export issues, missing attribute guards)Test plan
test_run_and_parse_picklepatchpasses locally (macOS — no-op sincestr(PosixPath)already uses/)uv run mypy codeflash/languages/python/support.py→ 0 errors