fix: measure individual call durations in sequential phase of concurrency decorator#2140
Merged
aseembits93 merged 2 commits intomainfrom May 7, 2026
Merged
fix: measure individual call durations in sequential phase of concurrency decorator#2140aseembits93 merged 2 commits intomainfrom
aseembits93 merged 2 commits intomainfrom
Conversation
…ency decorator The old approach timed the entire sequential loop (including event loop scheduling overhead between iterations), while the concurrent phase used asyncio.gather which has a fast-path with minimal inter-task overhead. This asymmetry inflated the sequential/concurrent ratio, causing false positives in concurrency gain detection. Sum per-iteration durations instead, excluding event loop scheduling overhead from the measurement.
KRRT7
force-pushed
the
cf-fix-concurrency-measurement
branch
from
808b76b to
342e902
Compare
5 tasks
KRRT7
force-pushed
the
cf-fix-concurrency-measurement
branch
from
51fb98a to
9399561
Compare
misrasaurabh1
approved these changes
May 7, 2026
aseembits93
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codeflash_concurrency_asyncthat inflated sequential/concurrent ratiosasyncio.gatherhas a fast-path with minimal inter-task overheadcodeflash_wrap_decorator.pyand the inlined copy ininstrument_existing_tests.pyTest plan
tests/test_async_concurrency_decorator.py— all 9 tests passtest_concurrency_decorator_blocking_functionno longer flaky (ratio stays < 2.0 reliably)