fix: resolve mypy strict errors in models.py and code_utils.py#2145
Merged
aseembits93 merged 2 commits intomainfrom May 8, 2026
Merged
fix: resolve mypy strict errors in models.py and code_utils.py#2145aseembits93 merged 2 commits intomainfrom
aseembits93 merged 2 commits intomainfrom
Conversation
- Fix return type of create_score_dictionary_from_metrics (dict[int, int] → dict[int, float]) - Restructure modify_addopts to eliminate type narrowing issues with TOMLDocument/ConfigParser branches - Fix contextmanager return types (None → Generator[None, None, None]) - Replace function-attribute pattern in get_run_tmp_file with module-level state - Add type: ignore[index] for tomlkit dynamic indexing - Guard original_content restore with None check in add_addopts_to_pyproject
Collaborator
Author
|
@aseembits93 can you merge this first? It's at the top of the #2132 stack — the rest of the PRs depend on it for clean prek/mypy passes. |
5 tasks
aseembits93
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
models.pyandcode_utils.pyStack
Part of #2132 linear stack (position 1). Replaces merged #2142.