Skip to content

Big Tracer bug fix #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2025
Merged

Big Tracer bug fix #353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1bc895
- trace also if seen only once
misrasaurabh1 Jun 20, 2025
9efe253
expected unit tests == 2 since both funcA and test_threadpool were tr…
KRRT7 Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions codeflash/tracer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ def __exit__(
if self.function_count[
str(function.file_name)
+ ":"
+ (function.class_name + ":" if function.class_name else "")
+ (function.class_name + "." if function.class_name else "")
+ function.function_name
]
> 0
Expand Down Expand Up @@ -353,7 +353,7 @@ def tracer_logic(self, frame: FrameType, event: str) -> None: # noqa: PLR0911
return
if function_qualified_name not in self.function_count:
# seeing this function for the first time
self.function_count[function_qualified_name] = 0
self.function_count[function_qualified_name] = 1
file_valid = filter_files_optimized(
file_path=file_name,
tests_root=Path(self.config["tests_root"]),
Expand Down
2 changes: 1 addition & 1 deletion tests/scripts/end_to_end_test_tracer_replay.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ def run_test(expected_improvement_pct: int) -> bool:
config = TestConfig(
trace_mode=True,
min_improvement_x=0.1,
expected_unit_tests=1,
expected_unit_tests=2,
coverage_expectations=[
CoverageExpectation(function_name="funcA", expected_coverage=100.0, expected_lines=[5, 6, 7, 8, 10, 13])
],
Expand Down
Loading