Skip to content

⚡️ Speed up function funcA by 18% #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

⚡️ Speed up function funcA by 18% #397

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions code_to_optimize/code_directories/simple_tracer_e2e/workload.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,8 @@


def funcA(number):
number = min(1000, number)

# Simplify the sum calculation using arithmetic progression formula for O(1) time
j = number * (number - 1) // 2

# Use a cached helper to very efficiently reuse results for each possible 'number'
number = min(number, 1000)
# Use a cached helper to efficiently reuse results for each possible 'number'
return _joined_number_str(number)


Expand Down Expand Up @@ -63,8 +59,8 @@ def test_models():

@lru_cache(maxsize=1001)
def _joined_number_str(n):
# Use list comprehension for best clarity/efficiency
return " ".join(str(i) for i in range(n))
# Use map for faster str conversion and generator with join, more efficient than list comprehension
return " ".join(map(str, range(n)))


if __name__ == "__main__":
Expand Down
Loading