Skip to content

⚡️ Speed up method TestsCache.compute_file_hash by 53% in PR #753 (test_cache_revival) #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 10, 2025
Merged

⚡️ Speed up method TestsCache.compute_file_hash by 53% in PR #753 (test_cache_revival) #810

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1445c38
Optimize TestsCache.compute_file_hash
codeflash-ai[bot] Oct 10, 2025
c3e2ec2
it's a pathy objectey
KRRT7 Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions codeflash/discovery/discover_unit_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,14 +158,16 @@ def get_function_to_test_map_for_file(
return result

@staticmethod
def compute_file_hash(path: str | Path) -> str:
def compute_file_hash(path: Path) -> str:
h = hashlib.sha256(usedforsecurity=False)
with Path(path).open("rb") as f:
with path.open("rb", buffering=0) as f:
buf = bytearray(8192)
mv = memoryview(buf)
while True:
chunk = f.read(8192)
if not chunk:
n = f.readinto(mv)
if n == 0:
break
h.update(chunk)
h.update(mv[:n])
return h.hexdigest()

def close(self) -> None:
Expand Down
Loading