Skip to content

[LSP] Hanle lsp-only tag correctly #862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 30, 2025
Merged

[LSP] Hanle lsp-only tag correctly #862

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
efe373a
handle lsp only tag
mohammedahmed18 Oct 28, 2025
7347f44
Merge branch 'main' into lsp/fix-lsp-tag
KRRT7 Oct 29, 2025
b3dc206
Merge branch 'main' into lsp/fix-lsp-tag
KRRT7 Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions codeflash/lsp/lsp_logger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,10 @@ def enhanced_log(
actual_log_fn(clean_msg, *args, **kwargs)
return

if not lsp_enabled:
# it's for LSP and LSP is disabled
return

# ---- LSP logging path ----
if is_normal_text_message:
clean_msg = add_heading_tags(clean_msg, tags)
Expand Down
4 changes: 3 additions & 1 deletion codeflash/lsp/lsp_message.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
from pathlib import Path
from typing import Any, Optional

from codeflash.lsp.helpers import replace_quotes_with_backticks, simplify_worktree_paths
from codeflash.lsp.helpers import is_LSP_enabled, replace_quotes_with_backticks, simplify_worktree_paths

json_primitive_types = (str, float, int, bool)
max_code_lines_before_collapse = 45
Expand Down Expand Up @@ -34,6 +34,8 @@ def type(self) -> str:
raise NotImplementedError

def serialize(self) -> str:
if not is_LSP_enabled():
return ""
from codeflash.lsp.beta import server

execution_ctx = server.execution_context_vars.get()
Expand Down
Loading