Dont format genfiles if disabled

codeflash/api/aiservice.py

@@ -4,7 +4,6 @@
 import os
 import platform
 import time
-from pathlib import Path
 from typing import TYPE_CHECKING, Any, cast
 
 import requests
@@ -24,6 +23,8 @@
 from codeflash.version import __version__ as codeflash_version
 
 if TYPE_CHECKING:
+    from pathlib import Path
+
     from codeflash.discovery.functions_to_optimize import FunctionToOptimize
     from codeflash.models.ExperimentMetadata import ExperimentMetadata
     from codeflash.models.models import AIServiceRefinerRequest
@@ -557,7 +558,6 @@ def get_optimization_review(
         function_trace_id: str,
         coverage_message: str,
         replay_tests: str,
-        root_dir: Path,
         concolic_tests: str,  # noqa: ARG002
         calling_fn_details: str,
     ) -> str:
@@ -583,18 +583,13 @@ def get_optimization_review(
         """
         diff_str = "\n".join(
             [
-                unified_diff_strings(
-                    code1=original_code[p],
-                    code2=new_code[p],
-                    fromfile=Path(p).relative_to(root_dir).as_posix(),
-                    tofile=Path(p).relative_to(root_dir).as_posix(),
-                )
+                unified_diff_strings(code1=original_code[p], code2=new_code[p])
                 for p in original_code
                 if not is_zero_diff(original_code[p], new_code[p])
             ]
         )
         code_diff = f"```diff\n{diff_str}\n```"
-        logger.info("!lsp|Computing Optimization Review…")
+        logger.info("loading|Reviewing Optimization…")
         payload = {
             "code_diff": code_diff,
             "explanation": explanation.raw_explanation_message,

codeflash/code_utils/formatter.py

@@ -97,6 +97,9 @@ def is_diff_line(line: str) -> bool:
 
 
 def format_generated_code(generated_test_source: str, formatter_cmds: list[str]) -> str:
+    formatter_name = formatter_cmds[0].lower() if formatter_cmds else "disabled"
+    if formatter_name == "disabled":  # nothing to do if no formatter provided
+        return re.sub(r"\n{2,}", "\n\n", generated_test_source)
     with tempfile.TemporaryDirectory() as test_dir_str:
         # try running formatter, if nothing changes (could be due to formatting failing or no actual formatting needed) return code with 2 or more newlines substituted with 2 newlines
         original_temp = Path(test_dir_str) / "original_temp.py"

codeflash/lsp/features/perform_optimization.py

@@ -134,4 +134,5 @@ def sync_perform_optimization(server: CodeflashLanguageServer, cancel_event: thr
         "patch_file": str(patch_path),
         "task_id": params.task_id,
         "explanation": best_optimization.explanation_v2,
+        "optimizationReview": function_optimizer.optimization_review.capitalize(),
     }

codeflash/optimization/function_optimizer.py

@@ -246,6 +246,7 @@ def __init__(
         self.executor = concurrent.futures.ThreadPoolExecutor(
             max_workers=n_tests + 3 if self.experiment_id is None else n_tests + 4
         )
+        self.optimization_review = ""
 
     def can_be_optimized(self) -> Result[tuple[bool, CodeOptimizationContext, dict[Path, str]], str]:
         should_run_experiment = self.experiment_id is not None
@@ -1502,15 +1503,17 @@ def process_review(
         raise_pr = not self.args.no_pr
         staging_review = self.args.staging_review
         opt_review_response = ""
+        # this will now run regardless of pr, staging review flags
+        try:
+            opt_review_response = self.aiservice_client.get_optimization_review(
+                **data, calling_fn_details=function_references
+            )
+        except Exception as e:
+            logger.debug(f"optimization review response failed, investigate {e}")
+        data["optimization_review"] = opt_review_response
+        self.optimization_review = opt_review_response
         if raise_pr or staging_review:
             data["root_dir"] = git_root_dir()
-            try:
-                opt_review_response = self.aiservice_client.get_optimization_review(
-                    **data, calling_fn_details=function_references
-                )
-            except Exception as e:
-                logger.debug(f"optimization review response failed, investigate {e}")
-            data["optimization_review"] = opt_review_response
         if raise_pr and not staging_review and opt_review_response != "low":
             data["git_remote"] = self.args.git_remote
             check_create_pr(**data)