-
Notifications
You must be signed in to change notification settings - Fork 22
Show Progress while profiling the candidate #968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
|
@mohammedahmed18 doesn't this make it a nested progress bar? I think there's a progress bar above it which will cause issues, at least in the CLI |
|
@KRRT7 they are not nested the first one ("testing optimized candidate") is for without this the cli will look like it's freezed |
|
great! thanks! |
PR Type
Enhancement
Description
Add progress bar for line profiling
Wrap profiler step with
progress_barImprove user feedback during optimization
Diagram Walkthrough
flowchart LR A["handle_successful_candidate"] -- "wraps" --> B["progress_bar('Running line-by-line profiling')"] B -- "executes" --> C["line_profiler_step(...)"] C -- "outputs" --> D["record_line_profiler_result"]File Walkthrough
function_optimizer.py
Add progress bar around line profiler stepcodeflash/optimization/function_optimizer.py
line_profiler_stepinprogress_bar.