Skip to content

⚡️ Speed up method UniversalBaseModel.json by 5% #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method UniversalBaseModel.json by 5% #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions src/cohere/core/pydantic_utilities.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@
from .serialization import convert_and_respect_annotation_metadata
from typing_extensions import TypeAlias

_DEFAULT_KWARGS = {"by_alias": True, "exclude_unset": True}

T = TypeVar("T")
Model = TypeVar("Model", bound=pydantic.BaseModel)

Expand Down Expand Up @@ -84,11 +86,14 @@ def construct(cls: Type["Model"], _fields_set: Optional[Set[str]] = None, **valu
return super().construct(_fields_set, **dealiased_object)

def json(self, **kwargs: Any) -> str:
kwargs_with_defaults = {
"by_alias": True,
"exclude_unset": True,
**kwargs,
}
# Fast path for no user-provided keyword overrides.
if not kwargs:
# IS_PYDANTIC_V2 must be visible in this scope—assume global as in original codebase.
if IS_PYDANTIC_V2:
return super().model_dump_json(**_DEFAULT_KWARGS) # type: ignore[misc]
return super().json(**_DEFAULT_KWARGS)
# Only merge when kwargs is present.
kwargs_with_defaults = {**_DEFAULT_KWARGS, **kwargs}
if IS_PYDANTIC_V2:
return super().model_dump_json(**kwargs_with_defaults) # type: ignore[misc]
return super().json(**kwargs_with_defaults)
Expand Down