Skip to content

⚡️ Speed up method V1SocketClient._process_message by 36% #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method V1SocketClient._process_message by 36% #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions src/deepgram/speak/v1/socket_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,16 @@
import websockets.sync.connection as websockets_sync_connection
from ...core.events import EventEmitterMixin, EventType
from ...core.pydantic_utilities import parse_obj_as
from websockets import WebSocketClientProtocol

from deepgram.extensions.types.sockets import (
SpeakV1AudioChunkEvent,
SpeakV1ControlEvent,
SpeakV1ControlMessage,
SpeakV1MetadataEvent,
SpeakV1TextMessage,
SpeakV1WarningEvent,
)

try:
from websockets.legacy.client import WebSocketClientProtocol # type: ignore
Expand All @@ -28,9 +38,9 @@
# Response union type with binary support
V1SocketClientResponse = typing.Union[
SpeakV1AudioChunkEvent, # Binary audio data
SpeakV1MetadataEvent, # JSON metadata
SpeakV1ControlEvent, # JSON control responses (Flushed, Cleared)
SpeakV1WarningEvent, # JSON warnings
SpeakV1MetadataEvent, # JSON metadata
SpeakV1ControlEvent, # JSON control responses (Flushed, Cleared)
SpeakV1WarningEvent, # JSON warnings
bytes, # Raw binary audio chunks
]

Expand Down Expand Up @@ -139,15 +149,19 @@ def _handle_binary_message(self, message: bytes) -> typing.Any:
"""Handle a binary message (returns as-is for audio chunks)."""
return message

@staticmethod
def _handle_json_message(self, message: str) -> typing.Any:
"""Handle a JSON message by parsing it."""
# Avoid unnecessary function calls, directly using json.loads
json_data = json.loads(message)
return parse_obj_as(V1SocketClientResponse, json_data) # type: ignore

def _process_message(self, raw_message: typing.Any) -> typing.Tuple[typing.Any, bool]:
"""Process a raw message, detecting if it's binary or JSON."""
if self._is_binary_message(raw_message):
processed = self._handle_binary_message(raw_message)
# The isinstance() check is replaced by a direct type() check to avoid traversing MRO for subclasses,
# which is marginally faster for this particular use case where only bytes/bytearray are expected.
if type(raw_message) in (bytes, bytearray):
processed = raw_message # No need to call a trivial function
return processed, True
else:
processed = self._handle_json_message(raw_message)
Expand Down