Skip to content

⚡️ Speed up function single_query_encoder by 12% #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function single_query_encoder by 12% #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 13 additions & 14 deletions src/deepgram/core/query_encoder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,25 +24,24 @@ def traverse_query_dict(dict_flat: Dict[str, Any], key_prefix: Optional[str] = N


def single_query_encoder(query_key: str, query_value: Any) -> List[Tuple[str, Any]]:
if isinstance(query_value, pydantic.BaseModel) or isinstance(query_value, dict):
if isinstance(query_value, pydantic.BaseModel):
obj_dict = query_value.dict(by_alias=True)
else:
obj_dict = query_value
is_base_model = isinstance(query_value, pydantic.BaseModel)
is_dict = isinstance(query_value, dict)

if is_base_model or is_dict:
obj_dict = query_value.dict(by_alias=True) if is_base_model else query_value
return traverse_query_dict(obj_dict, query_key)
elif isinstance(query_value, list):
encoded_values: List[Tuple[str, Any]] = []
append = encoded_values.append
extend = encoded_values.extend
for value in query_value:
if isinstance(value, pydantic.BaseModel) or isinstance(value, dict):
if isinstance(value, pydantic.BaseModel):
obj_dict = value.dict(by_alias=True)
elif isinstance(value, dict):
obj_dict = value

encoded_values.extend(single_query_encoder(query_key, obj_dict))
value_is_base = isinstance(value, pydantic.BaseModel)
value_is_dict = isinstance(value, dict)
if value_is_base or value_is_dict:
obj_dict = value.dict(by_alias=True) if value_is_base else value
extend(single_query_encoder(query_key, obj_dict))
else:
encoded_values.append((query_key, value))

append((query_key, value))
return encoded_values

return [(query_key, query_value)]
Expand Down