Conversation
Callers shouldn't need to pin a version — default to latest stable and let them override only when needed.
The Playwright container defaults to sh (dash) which doesn't
support ${var/pattern/replacement}. Explicit shell: bash fixes it.
Docker container filesystems don't support hardlinks between the UV cache and workspace. Suppress the warning and avoid the fallback penalty by setting copy mode explicitly.
Callers pass result: success/failure based on their needs. This lets the reusable workflow be used as a terminal gate job.
KRRT7
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ci-e2e-playwright.yml) with Docker container, matrix browsers, and configurable inputscontents: write→contents: read(was causingstartup_failurefor callers with restricted permissions)resultinput so callers can gate on upstream CI jobsUV_LINK_MODE=copyfor container jobs (Docker filesystems don't support hardlinks)shell: bashfor parameter expansion in test commandplaywright-versionoptional with a defaultTest plan
ready / ready)