Skip to content

⚡️ Speed up function resolve_ref by 37% #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function resolve_ref by 37% #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/openai/lib/_pydantic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,9 +121,12 @@ def resolve_ref(*, root: dict[str, object], ref: str) -> object:

path = ref[2:].split("/")
resolved = root
# Inline is_dict logic for significant perf improvement due to tight loop
for key in path:
value = resolved[key]
assert is_dict(value), f"encountered non-dictionary entry while resolving {ref} - {resolved}"
# Avoid function call overhead: replace is_dict with direct isinstance check
# We ignore type params as the original did, see is_dict def
assert isinstance(value, dict), f"encountered non-dictionary entry while resolving {ref} - {resolved}"
resolved = value

return resolved
Expand Down