Skip to content

⚡️ Speed up method AsyncFiles.delete by 8% #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method AsyncFiles.delete by 8% #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/openai/_base_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1861,19 +1861,20 @@ def make_request_options(
if extra_body is not None:
options["extra_json"] = cast(AnyMapping, extra_body)

if query is not None:
if query is not None and extra_query is not None:
options["params"] = {**query, **extra_query}
elif query is not None:
options["params"] = query

if extra_query is not None:
options["params"] = {**options.get("params", {}), **extra_query}
elif extra_query is not None:
options["params"] = extra_query

if not isinstance(timeout, NotGiven):
options["timeout"] = timeout

if idempotency_key is not None:
options["idempotency_key"] = idempotency_key

if is_given(post_parser):
if not isinstance(post_parser, NotGiven) and not isinstance(post_parser, Omit):
# internal
options["post_parser"] = post_parser # type: ignore

Expand Down