Skip to content

⚡️ Speed up method SyncPage._get_page_items by 69% #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method SyncPage._get_page_items by 69% #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/openai/pagination.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,7 @@ class SyncPage(BaseSyncPage[_T], BasePage[_T], Generic[_T]):

@override
def _get_page_items(self) -> List[_T]:
data = self.data
if not data:
return []
return data
return self.data if self.data else []

@override
def next_page_info(self) -> None:
Expand Down