Skip to content

⚡️ Speed up function __parse_auth_credentials by 24% #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function __parse_auth_credentials by 24% #109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions weaviate/connect/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,17 +36,17 @@ def __parse_weaviate_cloud_cluster_url(cluster_url: str) -> Tuple[str, str]:


def __parse_auth_credentials(creds: Union[str, AuthCredentials, None]) -> Optional[AuthCredentials]:
if isinstance(creds, str):
if creds is None:
# If no credentials are provided, return None.
return None
elif isinstance(creds, str):
# If the credentials are a string, assume it's an API key.
return Auth.api_key(creds)
elif isinstance(
creds, (_BearerToken, _ClientPassword, _ClientCredentials, _APIKey)
): # use AuthCredentials after python 3.9 has been removed
# If the credentials are already an AuthCredentials object, return it as is.
return creds
elif creds is None:
# If no credentials are provided, return None.
return None
else:
raise ValueError("Invalid auth credentials provided.")

Expand Down