Skip to content

⚡️ Speed up method _NamedVectors.text2vec_ollama by 5% #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method _NamedVectors.text2vec_ollama by 5% #89

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions weaviate/collections/classes/config_named_vectors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,14 +381,21 @@ def text2vec_ollama(
Docker users may need to specify an alias, such as `http://host.docker.internal:11434` so that the container can access the host machine.

"""
return _NamedVectorConfigCreate(
# Local variable assignment for faster access and potential C optimizations
VecConfig = _Text2VecOllamaConfig
NamedVecConfigCreate = _NamedVectorConfigCreate

vectorizer_config = VecConfig(
apiEndpoint=api_endpoint,
model=model,
vectorizeClassName=vectorize_collection_name,
)

# Re-arranged to reduce attribute lookup
return NamedVecConfigCreate(
name=name,
source_properties=source_properties,
vectorizer=_Text2VecOllamaConfig(
apiEndpoint=api_endpoint,
model=model,
vectorizeClassName=vectorize_collection_name,
),
vectorizer=vectorizer_config,
vector_index_config=vector_index_config,
)

Expand Down