Skip to content

⚡️ Speed up method _PQEncoderConfigUpdate.merge_with_existing by 22% #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method _PQEncoderConfigUpdate.merge_with_existing by 22% #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions weaviate/collections/classes/config_vector_index.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,10 @@ class _VectorIndexConfigFlatCreate(_VectorIndexConfigCreate):

@staticmethod
def vector_index_type() -> VectorIndexType:
return VectorIndexType.FLAT
# Use a cached class-level constant to avoid repeatedly looking up the class attribute
if not hasattr(_VectorIndexConfigFlatCreate, "_VECTOR_INDEX_TYPE_FLAT"):
_VectorIndexConfigFlatCreate._VECTOR_INDEX_TYPE_FLAT = VectorIndexType.FLAT
return _VectorIndexConfigFlatCreate._VECTOR_INDEX_TYPE_FLAT


class _VectorIndexConfigHNSWUpdate(_VectorIndexConfigUpdate):
Expand Down Expand Up @@ -236,10 +239,12 @@ def merge_with_existing(self, schema: Dict[str, Any]) -> Dict[str, Any]:

Errors shadowing type occur if we want to use type as a field name.
"""
if self.type_ is not None:
schema["type"] = str(self.type_.value)
if self.distribution is not None:
schema["distribution"] = str(self.distribution.value)
type_ = self.type_
distribution = self.distribution
if type_ is not None:
schema["type"] = str(type_.value)
if distribution is not None:
schema["distribution"] = str(distribution.value)
return schema


Expand Down