feat: move hotspots between screens via drag#8
Merged
trmquang93 merged 1 commit intomainfrom Mar 17, 2026
Merged
Conversation
Allow users to reposition a hotspot from one screen to another by dragging it beyond the source screen and releasing on a target screen. The hotspot stays at its original position during drag while a ghost preview follows the cursor showing the drop location. On release, the hotspot transfers to the target screen and all associated connections update their fromScreenId atomically. Single undo step via existing captureDragSnapshot/commitDragSnapshot pattern.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fromScreenIdto the new screencaptureDragSnapshot/commitDragSnapshotpatternChanges
canvasMath.js: AddworldToScreenPct()to convert world coordinates to percentage position within a screen's image areauseScreenManager.js: AddmoveHotspotToScreen()that atomically transfers a hotspot and updates connectionsuseCanvasMouseHandlers.js: Reposition drag now tracks world cursor without moving the hotspot live; mouseup computes final position viaworldToScreenPctfor both within-screen and cross-screen casesDrawd.jsx: WiremoveHotspotToScreen, render ghost preview rectangle during reposition dragcanvasMath.test.js: 4 new tests forworldToScreenPctTest plan
npm testpasses (233 tests)npm run lintclean