fix: prevent hotspot move on double-click and open edit modal#9
Merged
trmquang93 merged 1 commit intomainfrom Mar 17, 2026
Merged
fix: prevent hotspot move on double-click and open edit modal#9trmquang93 merged 1 commit intomainfrom
trmquang93 merged 1 commit intomainfrom
Conversation
Add drag threshold to hotspot reposition to prevent accidental moves during double-click. Introduce "reposition-pending" intermediate state that requires 5px mouse movement before committing to a drag. Double-clicking a hotspot now opens the HotspotModal for editing. Add ESC key support to close HotspotModal.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
npm test— 233 tests)