-
-
Notifications
You must be signed in to change notification settings - Fork 158
Fix Loading State in Newsfeed #2099
Copy link
Copy link
Open
Labels
Ready for DevelopmentAutomatically assigned to issues that are ready to be picked upAutomatically assigned to issues that are ready to be picked upfrontendFrontend developmentFrontend developmentgood first issueGood for newcomersGood for newcomers
Description
Summary
The Newsfeed currently has no loading state - between page load and the actual fetch of the notification data, we will display the "No Results" page state (that should only appear when the user has no notifications). It's actually even stranger - we do display a loading spinner temporarily, but will somehow still load the Newsfeed before the notification data is ready, causing this error. We may need to adjust the
This is misleading - we should modify this page so that we display a loading state until we have the real notifications data.
Success Criteria
- Add a "Loading" state to the Newsfeed page that displays until the Notifications data fetch call has finished
- No Figma here, but the current "Loading" state for the page would be acceptable (so long as we update the logic so it displays at the correct time).
- The "No Results" screen should never show at any point in the page load process if the user truly does have any notifications
Additional Links
Newsfeed component: https://github.com/codeforboston/maple/blob/main/components/Newsfeed/Newsfeed.tsx#L21
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Ready for DevelopmentAutomatically assigned to issues that are ready to be picked upAutomatically assigned to issues that are ready to be picked upfrontendFrontend developmentFrontend developmentgood first issueGood for newcomersGood for newcomers