Skip to content

Conversation

@delexagon
Copy link
Collaborator

@delexagon delexagon commented Jan 7, 2026

Summary

References issue #1994, does not close.

  • Changed retrieval of hearing data to getServerSideProps, so that an invalid hearing id refers to a 404 page
  • Changed previous transcriptions.ts to hearing.ts for common definition/fetch of hearing data
  • Described possible null states for components involving hearing sidebar
  • Fixed bug where Hearing+Transcription badge would show on page without Hearing or Transcription

Checklist

Strings are in locale

Screenshots

Nonexistent hearing:
Captura de pantalla_20260106_231348
Existing hearing:
Captura de pantalla_20260106_231441
Hearing without video or transcript:
Captura de pantalla_20260106_235138
Hearing without content.HearingAgendas[0].DocumentsInAgenda:
Captura de pantalla_20260106_231625
Hearing without content.HearingHost.CommitteeCode:
Captura de pantalla_20260106_232603
Hearing without content.HearingHost.GeneralCourtNumber:
Captura de pantalla_20260107_000434
Hearing without content.Name:
Captura de pantalla_20260106_233206
Hearing without parseable content.EventDate:
Captura de pantalla_20260106_233256
Hearing without videoTranscriptionId:
Captura de pantalla_20260106_233356

Known issues

N/A

Steps to test/reproduce

  1. Check that the hearing details page possesses all available features
  2. Check that a hearing that does not exist is returned with a 404 code and page
  3. Check that missing components in firebase content do not cause strange UI results (the above images should be representative)

@vercel
Copy link

vercel bot commented Jan 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
maple-dev Ready Ready Preview, Comment Jan 7, 2026 5:24am

Copy link
Collaborator

@Mephistic Mephistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Very thorough!

As per the hack night discussion, agreed that we may want other copy for the "tag" in the Browse Hearings Page for hearings that are:

  • Scheduled in the future (and would not be expected to have a video/transcript)
  • Never expected to have a video/transcript (e.g. Written Testimony Only hearings, or hearings that are only a public Zoom or Microsoft Teams link). We can estimate these as hearings that don't have a video/transcription within 24 hours of finishing (because that's way past our SLA)

@Mephistic Mephistic merged commit 4cb4c0c into codeforboston:main Jan 14, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants