Skip to content

Ballot Initiative Banner#2076

Merged
Mephistic merged 2 commits intocodeforboston:mainfrom
mertbagt:ballot_banner
Mar 24, 2026
Merged

Ballot Initiative Banner#2076
Mephistic merged 2 commits intocodeforboston:mainfrom
mertbagt:ballot_banner

Conversation

@mertbagt
Copy link
Collaborator

@mertbagt mertbagt commented Mar 23, 2026

Summary

Issue #2070

Checklist

  • On the frontend, I've made my strings translate-able.
  • [n/a] If I've added shared components, I've added a storybook story.
  • [n/a] I've made pages responsive and look good on mobile.
  • [n/a] If I've added new Firestore queries, I've added any new required indexes to firestore.indexes.json (Please do not only create indexes through the Firebase Web UI, even though the error messages may reccommend it - indexes created this way may be obliterated by subsequent deploys)

Screenshots

image

Known issues

none

Steps to test/reproduce

For each feature or bug fix, create a step by step list for how a reviewer can test it out. E.g.:

  1. Go to ../bills/194/H5010
  2. Check for orange ballot banner
  3. Check that sponsors are hidden
  4. Go to ../bills/194/H54
  5. Check that ballot banner is not present
  6. Check for sponsors

@vercel
Copy link

vercel bot commented Mar 23, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
maple-dev Ready Ready Preview, Comment Mar 23, 2026 3:06pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
maple-prod Ignored Ignored Mar 23, 2026 3:06pm

Request Review

let isBallotMeasure = false
const curComm = bill?.currentCommittee?.id

if (curComm == "SJ42") {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: We should probably make this a constant like currentGeneralCourt, but I'm going to do this as part of a follow-up PR, so we can ignore it for this PR.

@Mephistic Mephistic merged commit 1c2edbe into codeforboston:main Mar 24, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants