-
Notifications
You must be signed in to change notification settings - Fork 78
Added testimonials section #46
Added testimonials section #46
Conversation
|
Hey @sarthakkundra , CI is failing because you have many unused variables...Delete unused variables and deploy will work fine:) I think |
|
Also, rebase your branch to current development branch to resolve merge conflicts: Then you will have to resolve merge conflicts on your own... There will be two code blocks one is written by you and other is written in current development branch... You can just delete any of the two codeblocks, that works for your PR. once done: to confirm everything is working fine. Now do: and we can see your changes 🥇 |
|
@Abhishek-kumar09 Thanks for the help will do the changes :) |
|
@sarthakkundra , Is it running in your local machine, the build is failing here. |
|
@Abhishek-kumar09 I have made the changes and I was just pushing them after rebasing but I'm getting committing is not possible because I have unmerged files after resolving the conflict issues. I'm trying to fix that |
|
have you done rebasing? |
cb36a34 to
f63462d
Compare
|
@Abhishek-kumar09 Done! Thanks a lot for the help! 💯 |
|
Booyah! you have made it...:) |
|
@GangaChatrvedi @KeenWarrior , please review. |
Abhishek-kumar09
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes
src/views/pages/HomeView/Events.js
Outdated
| }, | ||
| cardMedia: { | ||
| paddingTop: '55.75%', // set 61.25% for 16:9 or highresolution images--- currently set to 55.75% to fit hqquality images. | ||
| paddingTop: '61.25%' // 16:9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please undo this change.
|
Kudos to your work @sarthakkundra There are some changes.
Please message here in case of any doubt in this PR. And on discord for any general concern. |
This will be fixed by this change https://github.com/codeforcauseorg/codeforcause.org/pull/46#pullrequestreview-452765869 |
|
@KeenWarrior I think this PR should close this issue :) |
|
Some more changes 😄
|
|
congrats @sarthakkundra , your first commit merged into codeforcause.org. Good Work! |



Created a new folder src/views/HomeView/Testimonials having the card layout and an index.js file to map through the data in src/views/HomeViewData.js to show the testimonials. #28
Side note :- I did a last minute change to make the alternate name dynamic in case there's no picture for the avatar which caused a merge conflict. Maybe this will help in resolving it. File :- src/views/HomeView/Testimonials/TestimonialCard.js Line :- 45