Migrate caff and sort-in-place tools#5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
caffandsort-in-placefromcodeforester/baseinto the Base Platform Tools CLI layout.bin/that delegate through Base'sbasectl.cli/bash/commands/.caffandsort-in-placeinbase_manifest.yaml.Issue
Closes #4
Validation
tests/validate.shbash -n bin/caff bin/sort-in-place cli/bash/commands/caff/caff.sh cli/bash/commands/sort-in-place/sort-in-place.sh tests/validate.shbats cli/bash/commands/caff/tests/caff.bats cli/bash/commands/sort-in-place/tests/sort-in-place.batsgit diff --check/Users/rameshhp/work/base/bin/basectl test base-platform-tools --workspace /Users/rameshhp/work/base-platform-tools-worktrees/Users/rameshhp/work/base/bin/basectl run base-platform-tools --workspace /Users/rameshhp/work/base-platform-tools-worktrees --list/Users/rameshhp/work/base/bin/basectl run base-platform-tools caff --workspace /Users/rameshhp/work/base-platform-tools-worktrees -- --help/Users/rameshhp/work/base/bin/basectl run base-platform-tools sort-in-place --workspace /Users/rameshhp/work/base-platform-tools-worktrees -- --helpbasectl testandbasectl runreport the expected warning that thebase-platform-toolsproject venv has not been created yet becausebasectl setup base-platform-toolshas not been run, then execute successfully.Platform Support
caffis macOS-specific because it depends on the macOScaffeinatecommand.sort-in-placeuses Bash andsort; it should work on macOS, Linux, and WSL where standard POSIX tools are available.caffbehavior.Notes
base-platform-tools.codeforester/basewill remove the old copies from Base after this PR is merged.