Skip to content

Threshold setup notifications#95

Merged
codeforester merged 1 commit into
masterfrom
hpr/setup-notification-threshold
May 27, 2026
Merged

Threshold setup notifications#95
codeforester merged 1 commit into
masterfrom
hpr/setup-notification-threshold

Conversation

@codeforester
Copy link
Copy Markdown
Owner

Summary

  • Send default macOS setup notifications only when setup runs for at least 30 seconds.
  • Add --notify as an explicit force option for quick runs while keeping --no-notify and BASE_SETUP_NOTIFY=false as opt-outs.
  • Add BASE_SETUP_NOTIFY_MIN_SECONDS to tune the default threshold.
  • Warn on macOS when --notify is requested but osascript is unavailable.
  • Update README and BATS coverage for thresholded, forced, disabled, dry-run, and missing-osascript behavior.

Validation

  • bash -n cli/bash/commands/basectl/subcommands/setup.sh
  • bash -n cli/bash/commands/basectl/subcommands/setup_common.sh
  • git diff --check
  • bats cli/bash/commands/basectl/tests/setup.bats
  • bats cli/bash/commands/basectl/tests/basectl.bats

@codeforester codeforester merged commit c541f9d into master May 27, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant