Development to Master (version update v0.0.4 to v0.0.5)

[leekahung]

This merge will incorporate the following changes listed from CHANGELOG.md as v0.0.4 in Master. It's been a while since our last update with version 0.0.3 (April 25th, 2023), but lots of new features been added. See below.

Note to Developers: In case you're encountering errors with regards to userlist.ttl such as not being able to delete users or see the person's webId, it might mean that you're still using an older version of userlist.ttl. In this update, userlist.ttl has been revamped to handle new input fields in a slightly different manner. To reset the userlist.ttl, simply delete it from your Solid Pod under Users, log out of PASS and log back in. A new userlist.ttl will be generated for you in the Pod and you'll be able to add/delete users again.

Visual Changes Since v0.0.4

Home

Clients (formerly Home)

Forms

Inbox

Outbox

CHANGELOG - v0.0.5 (June 7, 2023)

Features

• Updated UI for UserList and ManageUser with ClientList and AddClientModal (Issue 196/clients page #209)
• Generate PASS specific inbox and public container if it doesn't exist upon login (Issue 200/update generate container functions #201)
• Render sent message in outbox (Issue 190/render message outbox #191)
• Include pagination for messages in inbox/outbox (Issue 190/render message outbox #191)
• Generate user outbox on log in if outbox does exist in user's Solid Pod (Created function to build outbox when logging in for the first time #186)
• Using webIds instead of username as primary identifier (Issue 168/convert users to webids #169)
• Allow users to choose different Solid Identity Providers when using PASS (allow user to choose identity provider on signin #167)
• Updated/Enhanced UI for Footer, Inactivity Notification, Client List, Form components, etc. (Issue 144/enhance design and ux of inactivity notification #166, Issue-170/ Refactor Footer for decent mobile view #172, Issue 173/delete document styling updates #178, add margin to top of footer #180, Issue 174/cross pod search styling updates #187, Issue 188/check permission styling updates #193, Issue 194/set doc perms styling updates #206, Issue 196/clients page #209, Issue 195/set file perms styling updates #210)
• Render user messages from their Solid inbox on PASS (Issue 140/render ttl messages #148)

Fixes

• Refactored src/model-helpers/User.js to update user activity correctly (Issue 190/render message outbox #191, Add signed in user context #214)
• Corrected type in CrossPodWriteForm to use Upload instead of Search (Optimizing functions in session-core and updating JSDoc comments #183)
• Included corrections to JSDoc comments (Issue 140/render ttl messages #148, Development barcode #179, Optimizing functions in session-core and updating JSDoc comments #183, Optimizing functions in session-helper and updating JSDoc comments #184, Issue 200/update generate container functions #201)

Dev Changes

• Refactored all PASS related contexts to UserDataContext (Add signed in user context #214)
• Refactored React Contexts for messages to MessageContext (Add signed in user context #214)
• Include SignInUserContext for storing podUrl to be used in PASS (Add signed in user context #214)
• Refactored fetchData and App.jsx (Add signed in user context #214)
• Include top level mock directory to simplify module mocks in unit tests (Simplify Module Mocks in test cases #211)
• Refactoring custom hooks into individual files (Refactoring custom hooks #204)
• Replaced UPLOAD_TYPES with INTERACTION_TYPES (Replace UPLOAD_TYPES and FETCH_TYPES with INTERACTION_TYPES #202)
• Refactored PASS routing with AppRoutes and ProtectedRoutes (Issue 197/refactoring-routes #198)
• Created function to generate an outbox container for users if it doesn't exist in their Solid Pod (Created function to build outbox when logging in for the first time #186)
• Optimized session-helper functions (Optimizing functions in session-helper and updating JSDoc comments #184)
• Refactored set permission forms to pass in Access Object as a parameter to setDocAclPermission function (Optimizing functions in session-core and updating JSDoc comments #183)
• Updated all relevant components/functions using createDocAclForUser with new setDocAclForUser function (Optimizing functions in session-core and updating JSDoc comments #183)
• Optimized session-core functions (Optimizing functions in session-core and updating JSDoc comments #183)
• Included new JSDoc for new barcode scanner functions (Development barcode #179)
• Updated clearDoc.js and .gitignore to accomedate for new ZXing_barcaode.md (Development barcode #179)
• Organized utils directory into 4 subdirectories and rerouted import paths (Issue 155/organizing utils #171)
• Refactored contexts for userList from session-core to src/modal-helpers (Issue 168/convert users to webids #169)
• Replaced removeKeys function with localStorage.clear (allow user to choose identity provider on signin #167)
• Replaced previous Login component with OidcLoginComponent (allow user to choose identity provider on signin #167)
• Created new test directory to store unit tests (allow user to choose identity provider on signin #167)
• Generate loading text for when user messages are being loaded from Solid (Issue 140/render ttl messages #148)
• Removed types.d.ts in favor of better written JSDoc comments (Issue 140/render ttl messages #148)
• Created new React Context and components for rendering inbox messages (Issue 140/render ttl messages #148)
• Created new getInboxMessageTTL function to pull messages from Solid as JSON from TTLs (Issue 140/render ttl messages #148)

Others

• Updated package-lock.json to fix high-security vulnerabilities (Update package-lock dependencies to fix high-security vulnerability #224)
• Updated GitHub Actions to have lints and unit tests separate from building (Clean up warning messages in Github Actions #181)
• Updated GitHub Actions to run newer GitHub Actions workflows and correct node version (Clean up warning messages in Github Actions #181)
• Included new technical documentation for barcode scanner (Development barcode #179)

[xscottxbrownx]

Ok, so there is a "dd" in the theme - man, I'm sorry. Jumped the gun on some comments in other files.

BUT, the font doesn't actually display as bold - so this is probably not implemented correctly.

[leekahung]

Thinking of replacing it with just sx locally, think it'll be better than setting custom variants since the main point of the status message is just to indicate to the user what's happening.

[leekahung]

You're correct, but the htmlId here is used as a prop to pass in the value for id, see <select> in DocumentSelection.jsx where htmlId used as a prop and used as the id attribute

[xscottxbrownx]

@timbot1789 if you have time to look over this. It's 105 changed files.

You are more than welcome to look over all of them, but I think it would be really helpful to split up. I think for the sake of the project you would be better to review the utils, tests, and contexts files. I'm almost done going over the rest (at 73 of 105 reviewed.)

[leekahung]

Alright, gonna attempt some refactors for one of the issues mentioned in the comments here and put it in another PR to be merged to Development. It's pretty sizable so I've pushed it all there #236. If it looks good @xscottxbrownx, we'll merge it into this.

[leekahung]

Really minor, but have noticed local pod URL was misconfigured after Adam mentioned it on Discord.

Even though you could still log into PASS just fine with http://localhost:3000 and it will correct the right webId, it will generate a webId without the / at the end of the Solid Server (notice localhost:3000profile without the slash). Even though the final webId would still need to be altered to http://localhost:3000/test/profile/card#me, could easily fix the localhost:3000profile problem by including / to VITE_SOLID_IDENTITY_PROVIDER_DEV.

[xscottxbrownx]

looks like you found and fixed

[xscottxbrownx]

Approving all files that I reviewed.

I did not review:

• contexts folder
• hooks folder
• model-helpers folder
• utils folder
• test folder