Fixing Login issue in GitHub Pages#238
Merged
leekahung merged 1 commit intoDevelopmentfrom Jun 10, 2023
Merged
Conversation
…5 changes and updated package-lock.json via npm install and npm audit fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to before, there seems to be an issue with package-lock.json.
Fixes here include copying the older package-lock.json from commit 5eedf39 (which was the working package-lock.json used in v4) and updating that with
npm installandnpm audit fixin place of the existing package-lock.json file in Development.It still uses the original package.json from Development and all changes up to now remains untouched. This needs to be pushed into Master in order for GitHub Pages to work.