Skip to content
This repository was archived by the owner on Dec 19, 2021. It is now read-only.

Conversation

@NickSchimek
Copy link
Member

@NickSchimek NickSchimek commented Jul 18, 2021

Setting up postgresql as the db to run the test suite on the CI in preparation to be production ready
4 tests are failing. due to typing issues (SQLite does not enforce types so these failures are good and need to be fixed).

The following issues need to be resolved before we can use posrgres as the db:

@NickSchimek NickSchimek self-assigned this Jul 18, 2021
@NickSchimek NickSchimek marked this pull request as draft July 18, 2021 08:25
@NickSchimek NickSchimek marked this pull request as ready for review August 1, 2021 23:53
Copy link
Member

@aedwardg aedwardg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I got it to work on Windows and all tests pass. Let me know if you think it's worth it for me to type up Windows instructions as well.

@NickSchimek
Copy link
Member Author

yes please 👍 Thank you

@NickSchimek NickSchimek merged commit 2a0cdfe into development Aug 8, 2021
@NickSchimek NickSchimek deleted the postgresql_setup branch August 8, 2021 21:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants