fix: app-proxy fails to create a Workflow instance #1008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure the RoleBinding kind is explicitly set to "RoleBinding" and the role is set to "Role" for the app-proxy Argo workflows. This change improves clarity and consistency in the RBAC configuration.
ATGardner
requested review from
a team,
chen-keinan,
dmaizel,
eti-codefresh and
scme0
as code owners
Contributor
Author
|
/e2e |
This reverts commit b7c93e3.
Contributor
Author
|
/e2e |
eti-codefresh
approved these changes
Dec 17, 2025
zarbis
approved these changes
Dec 17, 2025
ATGardner
added a commit
that referenced
this pull request
Dec 17, 2025
Ensure the RoleBinding kind is explicitly set to "RoleBinding" and the role is set to "Role" for the app-proxy Argo workflows. This change improves clarity and consistency in the RBAC configuration.
ATGardner
added a commit
that referenced
this pull request
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
replace CluterRoleBinding to a non-existing ClusterRole
argo-serverwith RoleBinding to the existing Role.Why
this CRB was a leftover since moving argo-workflows to namespced-mode
Notes