Skip to content

fix(cf-common): rollout lib template #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 26, 2023
Merged

fix(cf-common): rollout lib template #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce21faa
fix(cf-common): rollout lib template
shirtabachii Feb 26, 2023
757ef97
fix(cf-common): rollout lib template
shirtabachii Feb 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/cf-common/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
appVersion: v0.0.0
description: Codefresh library chart
name: cf-common
version: 0.0.12
version: 0.0.13
type: library
keywords:
- codefresh
Expand Down
6 changes: 3 additions & 3 deletions charts/cf-common/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

Codefresh library chart

![Version: 0.0.12](https://img.shields.io/badge/Version-0.0.12-informational?style=flat-square) ![Type: library](https://img.shields.io/badge/Type-library-informational?style=flat-square) ![AppVersion: v0.0.0](https://img.shields.io/badge/AppVersion-v0.0.0-informational?style=flat-square)
![Version: 0.0.13](https://img.shields.io/badge/Version-0.0.13-informational?style=flat-square) ![Type: library](https://img.shields.io/badge/Type-library-informational?style=flat-square) ![AppVersion: v0.0.0](https://img.shields.io/badge/AppVersion-v0.0.0-informational?style=flat-square)

## Installing the Chart

Expand All @@ -18,7 +18,7 @@ Include this chart as a dependency in your `Chart.yaml` e.g.
# Chart.yaml
dependencies:
- name: cf-common
version: 0.0.12
version: 0.0.13
repository: https://chartmuseum.codefresh.io/cf-common
```

Expand Down Expand Up @@ -71,7 +71,7 @@ dependencies:
| controller.revisionHistoryLimit | string | `nil` | Set ReplicaSet revision history limit |
| controller.type | string | `nil` | Define the controller type (`deployment`) |
| extraResources | list | `[]` | Array of extra objects to deploy with the release |
| global | object | `{"env":{},"imagePullSecrets":[],"imageRegistry":"","rollout":{"analysis":{"successfulRunHistoryLimit":4,"unsuccessfulRunHistoryLimit":2},"canary":{"maxSurge":"25%","maxUnavailable":1,"steps":[{"setWeight":10},{"pause":{"duration":"1h"}},{"setWeight":20},{"pause":{"duration":{}}}]},"strategy":"Canary"}}` | Global parameters |
| global | object | `{"env":{},"imagePullSecrets":[],"imageRegistry":"","rollout":{"analysis":{"successfulRunHistoryLimit":null,"unsuccessfulRunHistoryLimit":null},"canary":{"maxSurge":null,"maxUnavailable":null,"steps":[{"setWeight":null},{"pause":{"duration":null}},{"setWeight":null},{"pause":{"duration":null}}]},"strategy":null}}` | Global parameters |
| global.env | object | `{}` | Global Env vars. NO precedence over `.Values.container.env` |
| global.imagePullSecrets | list | `[]` | Global Docker registry secret names as array |
| global.imageRegistry | string | `""` | Global Docker image registry |
Expand Down
2 changes: 0 additions & 2 deletions charts/cf-common/templates/controller/_rollout.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,6 @@ spec:
maxSurge: {{ default $.Values.global.rollout.canary.maxSurge .maxSurge }}
stableMetadata: {{ default $.Values.global.rollout.canary.stableMetadata .stableMetadata| toYaml | nindent 8 }}
canaryMetadata: {{ default $.Values.global.rollout.canary.canaryMetadata .canaryMetadata| toYaml | nindent 8 }}
stableService: {{ .stableService | default (printf "%s-stable" ( $fullName )) }}
canaryService: {{ .canaryService | default (printf "%s-canary" ( $fullName )) }}
steps: {{ default $.Values.global.rollout.canary.steps .steps | toYaml | nindent 6 }}
{{- end}}
{{- end }}
Expand Down