Skip to content

Conversation

@mikhail-klimko
Copy link
Collaborator

@mikhail-klimko mikhail-klimko commented Mar 7, 2023

What

Adding option to merge volumes and volumeMounts from globals.

global:
  volumes:
    global-ca-cert:
      ...
  container:
    volumeMounts:
      global-ca-cert:
        path:
          ...
  
volumes:
  ca-cert:
    ...

container:
  volumeMounts:
    ca-cert:
      path:
      ...

Whatever is specified in default values takes precedence over globals

Why

Need to pass volume and mount with custom CA certs for ANZ for almost every classic microservice.

Notes

CR-17037

@mikhail-klimko mikhail-klimko changed the title feat(cf-common): add extra volumes and mounts template feat(cf-common): add extra volumes and volumeMounts from globals Mar 9, 2023
@github-actions github-actions bot added the tests label Mar 9, 2023
@mikhail-klimko mikhail-klimko requested a review from a team March 9, 2023 10:28
@mikhail-klimko mikhail-klimko merged commit 547e2c8 into master Mar 9, 2023
@mikhail-klimko mikhail-klimko deleted the feat/add-extra-volumes-and-mounts branch March 9, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants