Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Apr 12, 2022

Removed the default value for the assignee as it is not needed if there is an escalation policy

Removed the default value for the assignee as it is not needed if there is an escalation policy
@ghost ghost requested a review from lrochette April 12, 2022 23:15
@ghost
Copy link
Author

ghost commented Apr 12, 2022

@lrochette I have updated the steps.yaml. Updated the version and remove the default value for ASSIGNEE_USER_ID. let me know if there is anything else needed.

Copy link
Contributor

@lrochette lrochette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the change based on the previous PR but I'm afraid it could break stuff for people who rely on that default value

@ghost
Copy link
Author

ghost commented Apr 13, 2022

This change is because there is an IF statement for ASSIGNEE_USER_ID. Why is the need for this if statement if we are passing in default values and it is not required? Also, you cannot use an escalation policy with this default value present.

Also, you cannot use False in the codefresh.yaml to disable this or not have a value for ASSIGNEE_USER_ID.

Please provide a better workaround @lrochette if you have one.

@ghost ghost requested a review from dustinvanbuskirk April 13, 2022 18:03
Copy link
Contributor

@lrochette lrochette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@ghost ghost merged commit 19344bf into master Apr 14, 2022
@ghost ghost deleted the xplrior-pagerduty-patch branch April 14, 2022 15:05
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant